ddio/lnxmouse.cpp: Code compression using lambdas #653
+98
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ton down This compresses repeated code in the sdlMouseButtonDownFilter function by introducing a lambda that is called with appropriate arguments for each mouse button press.
…ton up This compresses repeated code in the sdlMouseButtonUpFilter function by introducing a lambda that is called with appropriate arguments for each mouse button release.
This compresses repeated code in the sdlMouseWheelFilter function by introducing a lambda that is called with appropriate arguments for each vertical mouse wheel event.
|
Does this actually fix anything? I tend to be a little conservative when it comes to refactoring sections of the code that have no issues in the first place, it can sneakily introduce hard to notice problems without real benefits other than DRY-er code. |
|
It doesn't fix any runtime issue, it's purely code cosmetics. I see how this might introduce unforeseen issues although the changes are not too intrusive. The long term motivation for the changes was to make mouse wheel events first class citizens in the engine and this was a first code cleanup step. But actually I'm too busy to work on that atm so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
In ddio/lnxmouse.cpp there's a lot of code duplication that differs only by an integer or two. The given patches introduce lambdas that that are called instead of using duplicated inline code. This reduces the code size and helps to avoid errors in duplicated code.
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments